Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenCensus metric bridge to use the metric.Producer interface #3541

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Update OpenCensus metric bridge to use the metric.Producer interface #3541

merged 4 commits into from
Dec 19, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Dec 15, 2022 •
edited
Loading

Fixes #3504
Fixes #2204

This adds NewMetricProducer, and deprecates NewMetricExporter.

@dashpole dashpole force-pushed the opencensus_producer branch from 4f90174 to 1aa24bb Compare December 15, 2022 19:59
@dashpole dashpole added the pkg:bridges Related to a bridge package label Dec 15, 2022
@dashpole dashpole force-pushed the opencensus_producer branch from 1aa24bb to 7e521eb Compare December 15, 2022 20:02
@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Merging #3541 (a441af1) into main (4014204) will increase coverage by 0.0%.
The diff coverage is 96.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3541   +/-   ##
=====================================
  Coverage   78.0%   78.1%           
=====================================
  Files        164     164           
  Lines      11799   11815   +16     
=====================================
+ Hits        9212    9232   +20     
+ Misses      2391    2387    -4     
  Partials     196     196
Impacted Files Coverage Δ
internal/global/internal_logging.go 83.3% <87.5%> (+8.3%) ⬆️
bridge/opencensus/metric.go 92.5% <100.0%> (+7.5%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

MrAlias
MrAlias approved these changes Dec 15, 2022
View reviewed changes
bridge/opencensus/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/metric_test.go Outdated Show resolved Hide resolved
@dashpole dashpole force-pushed the opencensus_producer branch 2 times, most recently from 29d8970 to f4d3d26 Compare December 15, 2022 21:14
@dashpole dashpole mentioned this pull request Dec 15, 2022
Closed
@dashpole dashpole force-pushed the opencensus_producer branch from da3df7c to b3eef31 Compare December 19, 2022 14:51
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Dec 19, 2022
@MrAlias MrAlias merged commit a724cf8 into open-telemetry:main Dec 19, 2022
@dashpole dashpole deleted the opencensus_producer branch December 19, 2022 21:20
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Merged
@MrAlias MrAlias mentioned this pull request Aug 28, 2023
Merged
@MrAlias MrAlias mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
Metric v0.35.0
3 participants
@dashpole @MrAlias @hanyuancheung